Skip to content

Repository navigation

Drop Origin from public API. #656

Closed
#688
Closed
Drop Origin from public API.#656
#688
Labels
api changePRs that contain breaking public API changesgood first issueGood for newcomersrefactorIssues and PRs related to code refactoring

Description

@lovelydinosaur
lovelydinosaur
opened on Dec 20, 2019

We don't really need to expose Origin publically. For the sake of keeping the public API space slim we should...

  • Drop the url.origin property.
  • Drop Origin from the top-level export.
  • Move Origin into utils.py.
  • Use origin = Origin(url) in our internal usage, rather than url.origin.

Minor breaking change here, although I'm not sure we document origin anywhere or not.

Activity

  1. lovelydinosaur
    added
    refactorIssues and PRs related to code refactoring
    api changePRs that contain breaking public API changes
    on Dec 20, 2019
  2. florimondmanca
    added
    good first issueGood for newcomers
    on Dec 20, 2019
  3. aalvrz
    added 4 commits that reference this issue on Jan 1, 2020

    Drop `Origin` from public API

    fd73ead

    Drop `Origin` from public API

    9e438c0

    Drop `Origin` from public API

    b4e07e3

    Drop `Origin` from public API

    f1f3fb2
  4. lovelydinosaur
    closed this as completedin #688on Jan 7, 2020
  5. lovelydinosaur
    added a commit that references this issue on Jan 7, 2020

    Drop `Origin` from public API (#688)

    2b92a78
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    api changePRs that contain breaking public API changesgood first issueGood for newcomersrefactorIssues and PRs related to code refactoring

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions