Random KeyErrors when performing GET requests (possible race condition) #581

Activity

1. lovelydinosaur

   added

   http/2Issues and PRs related to HTTP/2Issues and PRs related to HTTP/2

   on Dec 2, 2019
2. lovelydinosaur commented on Dec 2, 2019

   

   lovelydinosaur

   on Dec 2, 2019

   Member

   More actions

   Thanks for reporting this.

   What's the simplest possible example that reproduces this reliably?
   Is this only occuring against a specific URL, or can you determine various cases where its failing?
3. KyleKreutzer commented on Dec 2, 2019

   

   KyleKreutzer

   on Dec 2, 2019

   Last edited by KyleKreutzer

   Author

   More actions

   I've only tried it against the Google Trends API (https://trends.google.com/trends/api/*). The simplest way to reproduce the error would be to pull https://github.com/KyleKreutzer/pytrends-async and run the unit tests using pytest w/pytest-asyncio. The problem is occurring intermittently so it may take more than 1 run to have the issue appear, but any of those tests seem to reliably reproduce the problem.

   Edit:
   I noticed that I did not have my Client objects wrapped with async with. I tried adding this, and it has not fixed the issue.
4. KyleKreutzer commented on Dec 2, 2019

   

   KyleKreutzer

   on Dec 2, 2019

   Last edited by KyleKreutzer

   Author

   More actions

       for i in range(100):
           async with httpx.Client() as c:
               resp = await c.get('https://trends.google.com/?geo={geo}'.format(geo='US'), timeout=5)
               time.sleep(1)
   

   This will reproduce the bug
5. millefalcon commented on Dec 6, 2019

   

   millefalcon

   on Dec 6, 2019

   Contributor

   More actions

   Is this still reproducible ?
   Couldn't reproduce it with:

   python3.6.9
   trio==0.13.0
   git+https://github.com/encode/httpx@75a439d7e2120edcddd8213df27dfeea28a2dc8c#egg=httpx
   
6. KyleKreutzer commented on Dec 6, 2019

   

   KyleKreutzer

   on Dec 6, 2019

   Author

   More actions

   I was able to reproduce it again with above code snippet on both mac and windows using 3.7.0 and 3.7.3. I am not using trio and am using version httpx==0.8.0 from pypi.
7. lovelydinosaur commented on Dec 8, 2019

   

   lovelydinosaur

   on Dec 8, 2019

   Member

   More actions

   Closed in master via #612
8. lovelydinosaur

   closed this as completedon Dec 8, 2019