You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently, the concurrency.py module is actually asyncio-specific. Preparing for alternative concurrency backend support, we should consider spinning it into a concurrency/asyncio.py, leaving room for backend-related stuff to go into concurrency package.
Yup. Let's also go for concurrency/base.py or concurrency/interfaces.py for the base interfaces, to keep things cleaner.
We may also want to not expose the concurrency interfaces at the top level of the httpx namespace, but instead end up with httpx.concurrency.BaseSemaphore etc... since we won't generally expect our user base to be implementing custom concurrency backends.
Activity
lovelydinosaur commentedon Aug 20, 2019
Yup. Let's also go for
concurrency/base.pyorconcurrency/interfaces.pyfor the base interfaces, to keep things cleaner.We may also want to not expose the concurrency interfaces at the top level of the
httpxnamespace, but instead end up withhttpx.concurrency.BaseSemaphoreetc... since we won't generally expect our user base to be implementing custom concurrency backends.florimondmanca commentedon Aug 20, 2019
Reopening this for the interfaces.py bit. :-)
florimondmanca commentedon Aug 20, 2019
Actually... -> #249