You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
scripts as a single top-level point of project automation. #239
It's benenficial from my POV, because it ends up that we can always just run scripts/install, or scripts/test from any project and expect that to perform the same kind of thing, even if we're using different tooling between projects. (eg. started adopting nox in some places, but not yet there accross the board.)
I'd like to do the same with httpx, while still keeping the niceness of nox (So eg. reintroduce a scripts/test, scripts/lint and scripts/publish.) but figure it's worth raising this for discussion first.
I'd also be quite keen on having a fast-feedback test suite being the default, with nox's run against multiple environments as an explicit case?
Any general thoughts here or should I just dive in and take a crack at this?
I'd say the scripts/install and scripts/lint scripts are rather straightforward and would be very helpful to have.
As for tests, I've been running $ pytest instead of nox to run tests against my virtual environment. Nox is too heavy for quick feedback, but running a complete pytest suite is moderately cheap (~15s). I also sometimes filter tests based on which ones I'm trying to get to pass, e.g. pytest -k "test_something" or pytest tests/test_foo.py.
So not sure whether scripts/test should default to pytest, or if it should also forward extra args for finer control?
Activity
florimondmanca commentedon Aug 19, 2019
Sharing my personal workflow here:
I'd say the
scripts/installandscripts/lintscripts are rather straightforward and would be very helpful to have.As for tests, I've been running
$ pytestinstead of nox to run tests against my virtual environment. Nox is too heavy for quick feedback, but running a complete pytest suite is moderately cheap (~15s). I also sometimes filter tests based on which ones I'm trying to get to pass, e.g.pytest -k "test_something"orpytest tests/test_foo.py.So not sure whether
scripts/testshould default topytest, or if it should also forward extra args for finer control?sethmlarson commentedon Aug 19, 2019
We can add
session.posargsto thetestnox session so that you can be narrower in your test executions. :)I have no issue with having the extra scripts, I didn't realize it was an encode org-wide thing.
lovelydinosaur commentedon Aug 20, 2019
Totally not a problem - I think
noxis a fantastic addition here, so not a big issue having to do a bit of rejigging to get there.