CertTypes keyfile and password should be Optional types.

SSLContext.load_cert_chain can take None as arguments values (docs) so I guess this:

Line 54 in c09e61d

CertTypes = Union[str, Tuple[str, str], Tuple[str, str, str]]

should be rewritten as follows:

CertTypes = Union[str, Tuple[str, Optional[str]], Tuple[str, Optional[str], Optional[str]]]

Hi,

Sounds legit, happy to review PRs towards that. :)

Feel like a type definition like that would be more readable broken over multiple lines, so many square brackets!

Navigation Menu