Repository navigation
socket.gaierror under trio not casted into httpx.ConnectError #1369
Description
Hello
Checklist
- The bug is reproducible against the latest release and/or
master. - There are no similar issues or pull requests to fix it yet.
To reproduce
import httpx
import trio
async def test():
async with httpx.AsyncClient() as client:
try:
await client.get("http://thisdoesnotexistasdf.com")
except httpx.ConnectError:
print("oops")
trio.run(test)
Expected behavior
should raise httpx.ConnectError
Actual behavior
raises socket.gaierror
Environment
- OS: linux
- Python version: 3.8.5
- HTTPX version: 0.16.1 and master 1bc3b01
- Async environment: trio, not happening on asyncio
- trio version: 0.17.0
Activity
jcugat commentedon Oct 27, 2020
Thanks for reporting this! It's an httpcore issue that was just fixed yesterday in encode/httpcore#225
kontsaki commentedon Oct 27, 2020
oh i should have searched through httpcore issues as well, thank you!
florimondmanca commentedon Oct 27, 2020
Still meaning to issue a bug fix release on the HTTPCore side, hopefully tomorrow, but feel free to ping. :)
jcugat commentedon Oct 28, 2020
No worries @kontsaki 😄