You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Support Sequence[Tuple[str, str]] type when setting cookies. #1209
Activity
lovelydinosaur commentedon Aug 21, 2020
We'd want to adjust the
__init__to handle that case properly...httpx/httpx/_models.py
Line 1045 in 15c1e42
And adjust the type signature...
httpx/httpx/_types.py
Line 48 in 15c1e42
Plus add a test case for it in here... https://github.com/encode/httpx/blob/master/tests/models/test_cookies.py
I guess use something like this...
Ideally do this in two commits - first add the (failing) test case, and then add the fixes.
Added test which checks that cookie might be built from a list of tup…
Made cookies constructable from a list of tuples (encode#1209)
Changed one of cookies types from List to Sequence (encode#1209)
Changed one of cookies types from List to Sequence (encode#1209)
Made cookies construct-able from a list of tuples (#1211)
lovelydinosaur commentedon Aug 25, 2020
Closed via #1211