Repository navigation
Don't call should_not_be_proxied on each request #1062
Description
Currently we're calling should_not_be_proxied on each request, which is problematic for two reasons...
- It's ignoring the
trust_env, and relying on an environment variable unilaterally. - It's preforming an extra chunk of work on each request that we'd rather not do.
Activity
cdeler commentedon Jul 20, 2020
@tomchristie
Do I understand correctly, that you told about working with requests on session level?
Something a-la introducing url->proxy transport cache on the Session level
Also there is a question about "trust_env". Do you mean this piece of code: httpx/_utils.py#L267 ?
So, please, could you help me, what should someone (e.g. me) do to complete the issue?
cdeler commentedon Jul 21, 2020
@tomchristie , @florimondmanca ^ if so, I can try to work on it. Please just advise me if I was right.
lovelydinosaur commentedon Jul 21, 2020
Not sure if I'd recommend contributors jumping on this one, since it might be a bit fiddly.