Skip to content

Fix up proxy header behaviour - #77

Merged
lovelydinosaur merged 3 commits into
masterfrom
proxy-header-behaviour
May 6, 2020
Merged

lovelydinosaur merged 3 commits into
masterfrom
proxy-header-behaviour

Conversation

@lovelydinosaur

Copy link
Copy Markdown
Member

Refs encode/httpx#929 (comment)

  • Add Host and Accept: */* headers by default on the tunnel CONNECT requests, if they're not already set.
  • De-duplicate proxy headers vs request headers on forwarded requests, rather than naively concatenating them.

I think we should probably roll a new version of httpcore from this, then issue an httpx 0.13.dev1.

Comment thread httpcore/_async/http_proxy.py

@yeraydiazdiaz yeraydiazdiaz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🎉

@lovelydinosaur
lovelydinosaur merged commit 701b57b into master May 6, 2020
@lovelydinosaur
lovelydinosaur deleted the proxy-header-behaviour branch May 6, 2020 09:36
@yeraydiazdiaz yeraydiazdiaz mentioned this pull request May 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants