Repository navigation
Add proxy_auth argument to HTTPProxy - #481
Merged
Merged
Conversation
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change allows users to specify a
proxy_authargument toHTTPProxy...Previously any authentication had to be included using the
proxy_headersargument, and the user was responsible for creating a correctly formed"Proxy-Authorization"header.This addition is prompted by the recent addition of
SOCKSProxy, which takes aproxy_authargument, and doesn't have anyproxy_headersargument, because HTTP headers aren't used with socks. Making sure both styles of proxy are aligned here feels more consistent.We'd also want a generic
proxy_authargument rather than a pre-built header if we ever want to be able to support both basic and digest auth styles. (Because we'd want to just be specifying the username and password, rather than pre-defining what HTTP headers and auth flow are expected by the proxy.)