Repository navigation
Drop flaky connection tests - #282
Merged
Merged
Conversation
florimondmanca
approved these changes
Mar 12, 2021
florimondmanca
left a comment
florimondmanca
left a comment
Contributor
There was a problem hiding this comment.
Yes, this confirms this test was the culprit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Giving this a quick tyre-kick based on #276, to double check it it is these test cases that are causing the current failures on master.
If so, then my assessment would be that flaky tests are worse than no tests, and that we should drop any flaky cases, but raise an issue to re-introduce them. That'd get us moving again, while still keeping an open issue for addressing this issue more comprehensively.