Repository navigation
Conversation
JayH5
marked this pull request as draft
February 7, 2021 12:40
Contributor
Author
|
😞 having trouble reproducing test failures locally.. may be a macOS vs Linux thing. |
Contributor
Author
|
Yep, this approach works on macOS but not Linux. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These tests are currently broken on master. They also don't really seem to be tests for connection timeouts, rather for the behaviour when trying to connect using SSL to a server that wasn't using SSL. This behaviour used to be a connection timeout, but now (at least on Python 3.7+) is an SSL error. I'm not sure what changed to cause this to happen (possibly different OpenSSL version?) but it would be good to know.
Change the
test_connection_timeout_tcptest to attempt to connect to a server port that is bound but not listening/accepting connections.Remove the
test_connection_timeout_udstest because as far as I can tell there isn't really a way to cause a timeout here (connect returns immediately with either success or failure on any bound Unix socket).Not super sure about the naming of things here...