Skip to content

Repository navigation

Tweak is_readable comment. - #244

Merged
florimondmanca merged 2 commits into
masterfrom
tomchristie-patch-1
Nov 30, 2020
Merged

Tweak is_readable comment.#244
florimondmanca merged 2 commits into
masterfrom
tomchristie-patch-1

Conversation

@lovelydinosaur

@lovelydinosaur lovelydinosaur commented Nov 30, 2020

Copy link
Copy Markdown
Member

What do we think about this to help users understand what an is_readable means for a disconnected socket?

@lovelydinosaur lovelydinosaur added the documentation Improvements or additions to documentation label Nov 30, 2020
florimondmanca
florimondmanca approved these changes Nov 30, 2020
View reviewed changes

@florimondmanca florimondmanca left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep!

@florimondmanca
florimondmanca merged commit ade4e09 into master Nov 30, 2020
@florimondmanca
florimondmanca deleted the tomchristie-patch-1 branch November 30, 2020 13:29
@florimondmanca florimondmanca mentioned this pull request Dec 7, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@florimondmanca florimondmanca florimondmanca approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

documentation Improvements or additions to documentation

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@lovelydinosaur @florimondmanca