Repository navigation
Fix import of HTTP/1.1 connection causing thread-safety bug on 3.9 - #237
Merged
Merged
Conversation
euri10
approved these changes
Nov 20, 2020
euri10
left a comment
euri10
left a comment
There was a problem hiding this comment.
very interesting, wasn't aware of this local / non-thread safe thing
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes encode/httpx#1393
Moves the local import of the HTTP/1.1 connection class to a global one. It wasn't necessary (
h11is always installed), and it's a non-threadsafe trick which started causingImportErroron Python 3.9 (that it worked in 3.8 and before was actually considered as a bug: https://bugs.python.org/issue35943).Also adds a basic test case to verify that
httpcore.SyncConnectionPoolcan indeed be used in thread-concurrent environments.Local testing showed that this is not a problem for
h2, so keeping that local import as-is for now.cc @senpos