Repository navigation
sdist is missing tests #798
Description
- [x ] Initially raised as discussion sdist is missing tests #796
The sdist package version 0.18.0 at PyPI is missing tests. This is regression from version 0.17.3. Please add tests back to sdist. Thank you.
Activity
karpetrosyan commentedon Sep 11, 2023
@mtelka Would you like to issue a PR resolving this?
lovelydinosaur commentedon Sep 11, 2023
How can I observe that this is a regression?
karpetrosyan commentedon Sep 11, 2023
This issue comes from #752. In 0.17.3 we have tests in sdist.
mtelka commentedon Sep 11, 2023
mtelka commentedon Sep 11, 2023
Sorry, no. ENOTIME.
mtelka commentedon Sep 11, 2023
It would be also great to include requirements.txt in sdist so we can automatically detect testing dependencies before we start tests.
Also, would you mind to add minimal
tox.ini? Something similar to this one?Thank you.
lovelydinosaur commentedon Sep 11, 2023
I've closed this issue due to lack of respect.
lovelydinosaur commentedon Sep 12, 2023
My response was unnecessarily brusque, here's what I could have said;
Following an "Sorry, no. ENOTIME." immediately with further requests for us to change our tooling is going to ellict a non-constructive response from me. It's disrespectful to the time & effort our team put into this project.
Getting back onto a collaborative track...
If you'd like to request either of those two tooling changes, I'd suggest opening a separate discussion for them.
mtelka commentedon Sep 12, 2023
Okay, @tomchristie you are right. Sorry for that. With ENOTIME I meant that there are a lot of build backends (hatch, poetry, flit, setuptools, ...) in the wild and all of them use a bit different way how to add things to sdist. Sometimes it is via
MANIFEST.in, sometimes using some config setup inpyproject.toml, etc.The actual (default) content of sdist even depends on tool versions used to create sdist. For example I faced a case when a project used some older version of build to create their sdists and so there were some file(s) missing in sdist. When I tried to create sdist for such a project using the latest version of build the sdist was complete. So the proper way how to fix missing file in sdist was just to upgrade build on the project's side (no code change was needed), IIRC. Or the difference was caused by some other tool in the chain? I do not remember :-).
This is something that is far better handled by developers of the project. It is usually trivial one-line change. The only problem is to find where the change needs to be done. A random bystander like me would need to spend far more time to find proper place for such a change than project developer. Thanks @karosis88 for the PR!
Again, I'm sorry for misunderstanding.
OTOH, now when I see how you are going to add tests to sdist I know how to deal with this stuff for
httpcore, so I can create PR with eithertox.iniorrequirements.txt.