using deprecated SSLContext() with no ssl.PROTOCOL_TLS_CLIENT flag #384

Activity

1. graingert commented on Jul 31, 2021

   

   graingert

   on Jul 31, 2021

   ContributorAuthor

   More actions

   I tried setting this to SSLContext(ssl.PROTOCOL_TLS_CLlENT) but then ssl couldn't get the local issuer certificate of hypercorn
2. lovelydinosaur commented on Nov 16, 2021

   

   lovelydinosaur

   on Nov 16, 2021

   Member

   More actions

   This is..... brief. 😅

   What's the issue here?
3. graingert commented on Nov 16, 2021

   

   graingert

   on Nov 16, 2021

   ContributorAuthor

   More actions

   This is..... brief. 😅

   What's the issue here?

   Calling SSLContext() (with no arguments) is deprecated and throws a warning with them enabled
4. lovelydinosaur commented on Nov 16, 2021

   

   lovelydinosaur

   on Nov 16, 2021

   Member

   More actions

   Ah yes... https://docs.python.org/3/library/ssl.html#ssl.SSLContext

   Deprecated since version 3.10: SSLContext without protocol argument is deprecated. The context class will either require PROTOCOL_TLS_CLIENT or PROTOCOL_TLS_SERVER protocol in the future.

   Assume this is no longer valid, since we're using ssl.create_default_context() now... https://github.com/encode/httpcore/blob/master/httpcore/_ssl.py
5. lovelydinosaur

   closed this as completedon Nov 16, 2021