Skip to content

Add tests for ConnectionPool #155

Closed
Closed

Description

@jcugat

In #153 was noticed that the parameters max_keepalive_connections / max_connections were not handled correctly in AsyncConnectionPool and SyncConnectionPool. Add some tests to cover it.

Activity

  1. cdeler commented on Aug 13, 2020

    @cdeler
    Contributor

    @jcugat I added the tests, but they are failing without the changes from #153 (I mean without self._max_keepalive = max_keepalive -> self._max_keepalive = max_keepalive_connections)

    (I can make the changes in my branch to check the tests)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions