Introduce UnsupportedProtocol exception. #124

Activity

1. lovelydinosaur

   added this to the 0.10.0 milestone on Jul 31, 2020
2. lovelydinosaur

   added

   enhancementNew feature or requestNew feature or request

   on Jul 31, 2020
3. lovelydinosaur commented on Jul 31, 2020

   

   lovelydinosaur

   on Jul 31, 2020

   Last edited by lovelydinosaur

   MemberAuthor

   More actions

   Thought: We also need to handle the no-host-in-URL case.

   Currently dealt with here: https://github.com/encode/httpx/blob/9409900898f40ed855e9c7a7664b7e068599a07d/httpx/_utils.py#L268-L282

   I guess we need both MissingHostname(...) and UnsupportedProtocol(...), then.

   We can drop httpx's InvalidURL after this, and instead mirror these two transport errors.
4. lovelydinosaur commented on Aug 2, 2020

   

   lovelydinosaur

   on Aug 2, 2020

   Last edited by lovelydinosaur

   MemberAuthor

   More actions

   Okay, so I don't think we want a MissingHostname exception class.
   Instead what we actually want for handling that case is to expand our ProtocolError, so...

   • ProtocolError
     • RemoteProtocolError
     • LocalProtocolError

   Everywhere we're currently raising it is a RemoteProtocolError, but we do actually want a small handful of LocalProtocolError cases, including...

   • Missing hostname in URL.
   • No Host header included. (Eg. that might expose in httpx if you create a invalid Request manually and .send() it.)

   Any similar cases.
5. lovelydinosaur

   closed this as completedin #128on Aug 2, 2020