connection leak in async connection pool

in AsyncConnectionPool.request

            except Exception:
                logger.trace("remove from pool connection=%r", connection)
                await self._remove_from_pool(connection)
                raise

the connection is not closed.

Closing this off as stale

I would say not stale. I just had the exact same issue. If you get a RemoteProtocolError(msg) of "Server disconnected without sending a response. ", the socket in the connection pool will be removed from the pool, but will not be closed. Maybe it eventually get garbage collected, but that takes quite some time. During which the server on the other side can't close the socket down completely.

This is like the main culprit behind a long running issue against philips tv's ( which i've blamed on buggy TVs :) )
home-assistant/core#57093
home-assistant/core#49801 (comment)

Navigation Menu

Repository navigation

connection leak in async connection pool #116

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

connection leak in async connection pool #116

Description

Activity

lovelydinosaur commented on May 6, 2021

elupus commented on Nov 9, 2021

elupus commented on Nov 9, 2021

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions