Skip to content

fix(metadata): XML-escape Info values in XMP metadata - #421

Open
EnesKartal wants to merge 1 commit into
empira:masterfrom
EnesKartal:fix/xmp-metadata-xml-escaping
Open

EnesKartal wants to merge 1 commit into
empira:masterfrom
EnesKartal:fix/xmp-metadata-xml-escaping

Conversation

@EnesKartal

Copy link
Copy Markdown

Fixes #419.

  • Escapes XML special characters (&, <, >, ", ') in PdfMetadata.CreateDefaultMetadata for all interpolated metadata fields (Producer, Keywords, Creator, CreationDate, ModificationDate, Title, Author, Subject, DocumentID, InstanceID).
  • Strips characters disallowed in XML 1.0 (control characters below U+0020 except tab, LF, CR, as well as U+FFFE / U+FFFF).
  • Adds unit test CreateDefaultMetadata_escapes_xml_and_strips_disallowed_control_chars in MetadataTests.cs verifying the generated XMP parses cleanly with XmlDocument.LoadXml.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

XMP metadata is not XML-escaped: '&' or '<' in Title or Author produce malformed XMP

1 participant