Repository navigation
Retry feed list load instead of idling forever - #47
Open
nickstouras wants to merge 1 commit into
Open
nickstouras wants to merge 1 commit into
nickstouras wants to merge 1 commit into
Conversation
sync_upload.php loads the local and remote feed list once at startup. If the remote server cannot be reached at that moment, e.g. when the service starts at boot before the network is up, the script continues with an empty feed list and logs "Nothing to upload" indefinitely. Since it never exits, systemd's Restart=always does not help, and syncing silently stops until the user presses sync in the UI. Exit when the initial load fails so that the service manager restarts the script. When a reload fails, keep the previous feed list and the reload flag so that the reload is retried, instead of replacing the feed list with the error response. Signed-off-by: Nikos Stouras <nickstouras@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sync_upload.php loads the local and remote feed list once at startup. If the remote server cannot be reached at that moment, e.g. when the service starts at boot before the network is up, the script continues with an empty feed list and logs "Nothing to upload" indefinitely. Since it never exits, systemd's Restart=always does not help, and syncing silently stops until the user presses sync in the UI.
Exit when the initial load fails so that the service manager restarts the script. When a reload fails, keep the previous feed list and the reload flag so that the reload is retried, instead of replacing the feed list with the error response.
closes #48