Repository navigation
Remove ember-cli-eslint as a dependency #7975
Description
I don't believe there's much value in having ember-cli-eslint as a dependency. We should advocate eslint through (1) editor integrations and (2) precommit-checks
This will simplify the eslint process and have the potential to make builds/rebuilds faster.
Thoughts @rwjblue @stefanpenner @scalvert
Activity
sangm commentedon Aug 13, 2018
I guess this proposes a separate, but related question: should
ember-clicome with something like https://github.com/typicode/husky so precommit hooks are easily integrated?kellyselden commentedon Aug 13, 2018
We have discussed this at the last team meeting. Consensus is the benefit is worth it, since it slows the build and doesn't cover the non-ember files we lint. It might be a worth an RFC, not sure.
sangm commentedon Aug 13, 2018
hey @kellyselden
Benefit is worth what? (Keeping or removing)
kellyselden commentedon Aug 13, 2018
Sorry, that was vague. Benefit of removing it.
sangm commentedon Aug 13, 2018
Great 🔥
In terms of needing a RFC or not, this is ambiguous. How do we make progress on this?
kellyselden commentedon Aug 13, 2018
I would say someone can create one and we can fast-track it.
Pros:
Cons:
sangm commentedon Aug 14, 2018
Have an initial draft of the RFC here: ember-cli/rfcs#121
kellyselden commentedon Dec 3, 2018
The RFC was merged, and there's a start of a PR here #8219.