Repository navigation
Conversation
Describes how Conquest (GA4GH WES and TES) runs Nextflow, Snakemake and WDL workflows and sends each task to its own Kubernetes cluster or to a remote TES service (Funnel, TESK), the call chain and the storage gateway, and which workflow types, workflows, engines and TES implementations were tested, with versions and results. Marked as a draft of test deployments.
Reviewer's GuideDocumentationAdd the draft Conquest guide describing the federation flow, routing, tested workflows and services, results, and limitations.
List the new guide in the Researchers index and site navigation, and add its Conquest reference link.
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Documentation build overview
|
There was a problem hiding this comment.
Hey - I've found 1 issue
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location path="docs/researchers/federated-workflows-conquest.md" line_range="127" />
<code_context>
+
+### Results
+
+Each workflow ran twice: with its tasks split across Kubernetes, Funnel and
+TESK, and with all tasks in Kubernetes. The results were compared.
+
</code_context>
<issue_to_address>
**Federated run counts are unexplained**
When the sarek `test` profile results are read alongside the stated run count, the results say each workflow ran once federated and once locally, but the sarek `test` row lists two separate federated task distributions without explaining them. Readers cannot tell how many runs were compared or reproduce that result.
Clarify what each sarek `test` task distribution represents and how many federated and local runs were compared.
Also at `docs/researchers/federated-workflows-conquest.md:133`.
</issue_to_address>Sourcery assessment
Approval pending. 1 finding to address first.
Blocking findings: docs/researchers/federated-workflows-conquest.md:127
|
|
||
| ### Results | ||
|
|
||
| Each workflow ran twice: with its tasks split across Kubernetes, Funnel and |
There was a problem hiding this comment.
🟡 Medium · Federated run counts are unexplained
When the sarek test profile results are read alongside the stated run count, the results say each workflow ran once federated and once locally, but the sarek test row lists two separate federated task distributions without explaining them. Readers cannot tell how many runs were compared or reproduce that result.
Clarify what each sarek test task distribution represents and how many federated and local runs were compared.
Also at docs/researchers/federated-workflows-conquest.md:133.
Prompt for AI agents
In `docs/researchers/federated-workflows-conquest.md` at line 127:
**Federated run counts are unexplained**
When the sarek `test` profile results are read alongside the stated run count, the results say each workflow ran once federated and once locally, but the sarek `test` row lists two separate federated task distributions without explaining them. Readers cannot tell how many runs were compared or reproduce that result.
Clarify what each sarek `test` task distribution represents and how many federated and local runs were compared.
Also at `docs/researchers/federated-workflows-conquest.md:133`.
Adds Federate Workflows with Conquest under Researchers, as Alex asked. It's a draft, marked as such on the page, to grow as the setup matures.
What's on the page
Same structure as the other Researchers pages: intro, a draft warning, then:
assemble_refbased, rna-seq-star-deseq2;developplus #1488, TESK with tesk-api#133 and tesk-core#134.The index table and the nav link to the page, and
includes/references.mdgains a[conquest]reference.Checks
python scripts/check_names.py,mkdocs build --strictandpytestpass locally.Summary by Sourcery
Document draft support for federating workflow tasks with Conquest across local and remote compute services.
New Features:
Enhancements:
Documentation: