Repository navigation
docs: add notes of v1.2.0 - #81
Merged
Merged
Conversation
Add the curated release notes of v1.2.0: release assets in publish-release, pip check in scan-image, and the gate cancel fix. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Reviewer's GuideDocumentationAdd curated v1.2.0 release notes covering action changes, gate concurrency guidance, and maintenance updates.
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
uniqueg
marked this pull request as ready for review
November 15, 2026 21:51
Linked issuesChecked at commit 8a72587 #80 docs: add notes of v1.2.0 · 5 of 6 met · 1 to check by hand
|
There was a problem hiding this comment.
Hey - I've found 4 issues
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location path="docs/releases/v1.2.0.md" line_range="6" />
<code_context>
+Release v1.2.0 of the shared actions of ELIXIR On-Cloud adds the input
+`assets` to the action `publish-release`, which attaches files (e.g., a
+packaged Helm chart) to the GitHub release, also in repositories with
+immutable releases. The action `scan-image` now fails scans of images that
+contain pip, and the action `gate` cancels pull request runs only for new
+commits. The action `pr-title` is unchanged. Callers pin
</code_context>
<issue_to_address>
**Pip images still pass**
When callers update the pin without setting `fail-on-pip` to `true`, `scan-image` defaults `fail-on-pip` to `false`, so its pip check does not reject images containing pip and those scans pass despite the release note.
Clarify in the release notes that rejecting images containing pip requires callers to enable `fail-on-pip`.
Also at `docs/releases/v1.2.0.md:8`, `docs/releases/v1.2.0.md:15`.
</issue_to_address>
### Comment 2
<location path="docs/releases/v1.2.0.md" line_range="7" />
<code_context>
+`assets` to the action `publish-release`, which attaches files (e.g., a
+packaged Helm chart) to the GitHub release, also in repositories with
+immutable releases. The action `scan-image` now fails scans of images that
+contain pip, and the action `gate` cancels pull request runs only for new
+commits. The action `pr-title` is unchanged. Callers pin
+`elixir-cloud-aai/.github/actions/<name>@<commit> # v1.2.0`; Dependabot
</code_context>
<issue_to_address>
**Pinned gate leaves runs uncanceled**
When callers update the `gate` pin without changing their workflow concurrency settings, the `gate` action only checks job results; caller workflow concurrency settings control cancellation, so updating the pin alone does not make runs cancel only for new commits.
Clarify in the release notes that callers must configure workflow-level concurrency to get the cancellation behavior.
Also at `docs/releases/v1.2.0.md:19`.
</issue_to_address>
### Comment 3
<location path="docs/releases/v1.2.0.md" line_range="3-7" />
<code_context>
+# v1.2.0
+
+Release v1.2.0 of the shared actions of ELIXIR On-Cloud adds the input
+`assets` to the action `publish-release`, which attaches files (e.g., a
+packaged Helm chart) to the GitHub release, also in repositories with
+immutable releases. The action `scan-image` now fails scans of images that
+contain pip, and the action `gate` cancels pull request runs only for new
+commits. The action `pr-title` is unchanged. Callers pin
+`elixir-cloud-aai/.github/actions/<name>@<commit> # v1.2.0`; Dependabot
</code_context>
<issue_to_address>
**Concurrent changes go undocumented**
When an action PR merges to `main` after this notes file is merged but before the release tag is created, `release.sh check` validates the version and tagged commit, but not whether these notes cover every change on that commit. If another action PR merges after the notes PR and before the maintainer tags `main`, the release workflow publishes that change with this notes file, so callers see an undocumented change.
Before tagging, reconcile the notes against the exact commit to be released, or prevent other changes from entering that release commit.
</issue_to_address>
### Comment 4
<location path="docs/releases/v1.2.0.md" line_range="8-9" />
<code_context>
+packaged Helm chart) to the GitHub release, also in repositories with
+immutable releases. The action `scan-image` now fails scans of images that
+contain pip, and the action `gate` cancels pull request runs only for new
+commits. The action `pr-title` is unchanged. Callers pin
+`elixir-cloud-aai/.github/actions/<name>@<commit> # v1.2.0`; Dependabot
+proposes the update.
+
</code_context>
<issue_to_address>
**Gate pin leaves cancellation unchanged**
Also at `docs/releases/v1.2.0.md:19`.
</issue_to_address>Sourcery assessment
Approval pending. 4 findings to address first.
Blocking findings: docs/releases/v1.2.0.md:6, docs/releases/v1.2.0.md:7, docs/releases/v1.2.0.md:7, docs/releases/v1.2.0.md:9
State that fail-on-pip defaults to false and that the gate fix is documented concurrency settings callers adopt, not an action change. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the curated release notes of v1.2.0 (
docs/releases/v1.2.0.md), asRELEASING.mdasks before the tag: release assets inpublish-release(#77, #79), the pip check inscan-image(#55, #74), the gate cancel fix (#72, #71), and maintenance (#75, #76, #64).Closes #80
Verification
bash .github/scripts/release.sh lint v1.2.0 docs/releases/v1.2.0.md: passes.Declined review findings
Light lane: docs only (one new release notes file); reviewed the diff myself.
🤖 Generated with Claude Code