You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Mar 4, 2020. It is now read-only.
Repository navigation
This repository was archived by the owner on Mar 4, 2020. It is now read-only.
Currently we have about 20 commits based on upstream node's head, we should keep our patches as minimum as possible and try to get some of them into upstream.
@zcbenz is there a way we (io.js / node) can better support you in this? We'd like to help reduce the number floating patches required for embedders, if possible.
@Fishrock123 For simple patches I usually just create a pull request to the repo, like libuv/libuv#395, but most of our patches are dirty hacks, it takes a lot of efforts to make them decent APIs with test cases, which I don't have time to do now. But eventually when I got time I would love to merge them to upstream.
@refack I'm going to go through the patches in this issue.
Hide console window when creating process. e6afee6
Generally we should have an option in libuv and Node.js for this flag, but it is useless for console apps and in Electron (and other embedders) we definitely want to have it on by default.
So we can probably add a build flag in libuv to turn it on by default.
We need this for security, so desktop apps won't accidentally load a module installed on user's system.
Maybe adding adding a new flag like what we did with process._noBrowserGlobals?
Don't set wrapper class in node, otherwise heap snapshot would crash. 6a24dd7
We commented that code out because it conflicts with blink web engine, no idea how to do with it.
Guard against NULL returned by uv_err_name. 124a0f2
Some antivirus and firewall softwares can block socket connections from other software clients, on our side we would get an unnormal errorno which would make uv_err_name return nullptr. I think the biggest challenge is how to represent an unknown error.
Activity
Do not depend on node to set include_dirs.
zcbenz commentedon Dec 20, 2013
Tried to merge one patch to upstream: nodejs/node-v0.x-archive#6744.
nathansobo commentedon Dec 20, 2013
Nice. Glad you're doing this. Looks like they're open to it?
zcbenz commentedon Dec 21, 2013
Yeah they are not against it, but it's not easy to persuade them to accept it too.
probablycorey commentedon Jun 24, 2014
Any updates on this @zcbenz?
zcbenz commentedon Jun 25, 2014
No news yet, but I have added more information in that PR since atom had been publicized, hoping it could add chances to get our patches merged.
zcbenz commentedon Aug 15, 2014
A small patch merged to upstream: nodejs/node-v0.x-archive#8122.
nathansobo commentedon Aug 15, 2014
Nice work @zcbenz ✨
zcbenz commentedon Jan 7, 2015
Another patch merged to io.js.
zcbenz commentedon Jan 20, 2015
Another one merged.
Fishrock123 commentedon Jun 30, 2015
@zcbenz is there a way we (io.js / node) can better support you in this? We'd like to help reduce the number floating patches required for embedders, if possible.
Fishrock123 commentedon Jun 30, 2015
It looks like a good amount of the patches are actually on libuv. Have you thought about submitting them to https://github.com/libuv/libuv?
zcbenz commentedon Jul 5, 2015
@Fishrock123 For simple patches I usually just create a pull request to the repo, like libuv/libuv#395, but most of our patches are dirty hacks, it takes a lot of efforts to make them decent APIs with test cases, which I don't have time to do now. But eventually when I got time I would love to merge them to upstream.
Fishrock123 commentedon Jul 7, 2015
Right, but don't be afraid to open issues for some things too! We do need to know what is necessary to make embedders' lives better. :)
refack commentedon Sep 28, 2017
Hello all,
If you need someone to help port stuff to mainline node, feel free to ping me.
I'm quite sure that beside me there are other node contributors that would be happy to help turn hacks into APIs.
And RE: dc8fe9d there's a PR open to make those opt-in nodejs/node#15454
zcbenz commentedon Oct 2, 2017
@refack That would be great help!
refack commentedon Oct 2, 2017
I'll take a look at the diff. If you could prioritize stuff, that would help me help you ;)
zcbenz commentedon Oct 3, 2017
@refack I'm going to go through the patches in this issue.
Hide console window when creating process.
e6afee6
Generally we should have an option in libuv and Node.js for this flag, but it is useless for console apps and in Electron (and other embedders) we definitely want to have it on by default.
So we can probably add a build flag in libuv to turn it on by default.
Make Module.globalPaths a reference.
f4ad6b7
We need this for security, so desktop apps won't accidentally load a module installed on user's system.
Maybe adding adding a new flag like what we did with
process._noBrowserGlobals?Don't set wrapper class in node, otherwise heap snapshot would crash.
6a24dd7
We commented that code out because it conflicts with blink web engine, no idea how to do with it.
Guard against NULL returned by uv_err_name.
124a0f2
Some antivirus and firewall softwares can block socket connections from other software clients, on our side we would get an unnormal
errornowhich would makeuv_err_namereturnnullptr. I think the biggest challenge is how to represent an unknown error.test: allow tests to pass without internet
http: remove adapter frame from onParserExecute
http: remove adapter frame from onParserExecute