Repository navigation
build(deps): replace ora with yocto-spinner - #214
claude[bot] wants to merge 2 commits into
Conversation
picospinner has no runtime dependencies, so this drops ora and its 16 transitive packages from the dependency tree. picospinner does not detect non-interactive output itself, so bin.ts only animates when stderr is an interactive terminal and otherwise prints the start and final lines, matching ora's previous behaviour in CI and when piped. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01R1iLgtNj9JZPkuSQCZbGfR
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
yocto-spinner handles non-interactive output itself, so the custom fallback helper in bin.ts is no longer needed and the port maps directly onto ora's API. Its only dependency is yoctocolors, which has no dependencies of its own. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01R1iLgtNj9JZPkuSQCZbGfR
claude
Bot
changed the title
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
LGTM — straightforward dependency swap.
What was reviewed: the ora -> yocto-spinner substitution in src/bin.ts (import, construction via yoctoSpinner({ text }).start(), and the fail/succeed -> error/success method renames) against yocto-spinner's actual API; package.json's dependency entry swap; and yarn.lock, where the new entry only adds yocto-spinner + its single dependency yoctocolors, consistent with the described net removal of ora's transitive packages.
Extended reasoning...
Three-file diff: package.json swaps the ora dep for yocto-spinner, src/bin.ts updates the import/construction and renames two spinner methods (fail->error, succeed->success) to match the new library's API, and yarn.lock is regenerated accordingly with only yocto-spinner and its one dependency (yoctocolors) added. No security-sensitive surface (no auth, crypto, injection, or data exposure involved) — this only affects CLI progress-spinner output. The mapping from ora's API to yocto-spinner's is mechanical and 1:1, the lockfile change is consistent with the claimed dependency-tree shrink, and the PR already has a human APPROVED review with no outstanding objections.
This branch has not been deployed
2 participants
Requested by David Babenko-Sanders · Slack thread
This replaces ora with yocto-spinner. It has a single tiny dependency (yoctocolors, which has none of its own) and handles non-interactive output itself, so bin.ts maps directly onto its API. The lockfile drops ora and its 16 transitive packages and adds two, a net removal of 15 entries. In an interactive terminal the CLI output is visually unchanged: the same messages, colors, ✔ and ✖ symbols, exit codes and stderr output. When piped or in CI there are a few small differences. The first line now shows the spinner frame instead of a dash, the "Generating API" step gets its own line (ora skipped it), and the frame and symbol can carry color codes when the environment advertises color support.
🤖 Generated with Claude Code
https://claude.ai/code/session_01R1iLgtNj9JZPkuSQCZbGfR