Skip to content

ci: bump pinned Node.js to 22.23.4 security release - #393

Merged
dsanders11 merged 1 commit into
mainfrom
chore/node-security-pins
Oct 21, 2026
Merged

dsanders11 merged 1 commit into
mainfrom
chore/node-security-pins

Conversation

@claude

@claude claude Bot commented Oct 21, 2026

Copy link
Copy Markdown
Contributor

Requested by Samuel Attard · Slack thread

This bumps the pinned Node.js version in .nvmrc and the test matrix from 22.12 / 22.12.x to 22.23.4, the October 2026 Node.js security release for the 22.x line. The test matrix entry previously tracked the engines minimum (22.12), so CI now tests on 22.23.4 instead while engines is unchanged.


Generated by Claude Code

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MM6DBDZdmumVSaiGNt2vF7
@claude
claude Bot requested a review from a team as a code owner October 21, 2026 22:31
@claude

claude Bot commented Oct 21, 2026

Copy link
Copy Markdown
Contributor Author

CI note: Test (41, 22.23.4, ubuntu-latest) (and Test (45, 22.23.4, ubuntu-latest) in the same run) failed in the Electron spec runner, not because of this PR. The failing assertions (should load the extension in newly created sessions after a "Failed to start Devtron service-worker ... trying again" retry, and the ipcRenderer.sendSync / ipcMain.handleOnce tracking tests) are the same intermittent failures seen with the old 22.12.x pin on unrelated PRs (e.g. runs 37498976034 and 39675277357). These specs run inside Electron's bundled Node, so the setup-node version doesn't affect them. Re-running the failed jobs once.


Generated by Claude Code

@dsanders11
dsanders11 merged commit 3f50915 into main Oct 21, 2026
64 of 67 checks passed
@dsanders11
dsanders11 deleted the chore/node-security-pins branch October 21, 2026 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants