Create BeatTable #238 #239 #240

[valentinbujdoso]

Fix #238 #239 #240

[magwas]

The beat table is supposed to contain pairs. See https://github.com/andrewcmyers/civs/blob/master/cgi-bin/beatpath2.pm
Entities describe data structures, hence contain only public fields, and live in package org.rulez.demokracia.pdengine.dataobjects
The behaviour related to an entity is in a class derived from it.
Use Matrix as the backing type for a beat table.
Listen to sonar. A lot of times he is right.
If you have questions, ask. I'm here to help.

[magwas]

Also I expect sonar to find legitimate issues, please take care of them, too.

[magwas]

At least some of the code duplication findings, none of the linguistic antipattern and all other findings by sonar seem to be legit. Of course do not comment, but fix scope.

[magwas]

there are still legit sonar findings.

[valentinbujdoso]

@magwas As I see there are some duplicated codes in sonar but I cannot eliminate it in a nice way.
Could you take a look?

[magwas]

There are actual code duplications using.

	result = beatTable.matrix.getElement(choice1, choice2);
	assertTrue(result.winning == pair.winning && result.losing == pair.losing);

Also you use the exact same code to test different things in setPair and getPair test, which means that some of the tests are redundant.

Please note that there are other problems, for example the complexity of BeatTable.
I have experimented with the traits pattern we were talking about, and BeatTable can be made as simple as

public class BeatTable extends MapMatrix<Choice, Pair> implements Matrix<Choice, Pair>, ContainingBeats {

	private static final long serialVersionUID = 1L;

	public BeatTable(final Collection<Choice> keyCollection) {
		super(keyCollection);
	}

}

[valentinbujdoso]

@magwas Could you run the sonar to not whine about the public entites?

[magwas]

use assertUnimplemented

[valentinbujdoso]

as I see there is no such a method like assertUnimplemented yet.

[valentinbujdoso]

Ok I think I created that method I hope you will like it. :)

[magwas]

Nice work

[magwas]

testcaseCount=10