Repository navigation
Fix CJK PDF round-trip font handling - #1
Merged
Merged
Conversation
loong10k
changed the title
loong10k
marked this pull request as ready for review
October 31, 2026 16:46
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI installs fonts-droid-fallback and exposes /usr/share/fonts/truetype/droid/DroidSansFallbackFull.ttf as EASYPDF_CJK_FONT. HtmlPdfConverter registers that configured font and creates a document-scoped iText FontProvider from its shared font set.
Layout regression correction: remove the whole-page aligned-column merge, which incorrectly converted three-line reading columns into tables and counted font runs as rows. Keep independent columns; apply 1pt tolerance only to the estimated within-line cell-gap boundary. Restore the original auto-width table/summary fixtures; retain a wide-table case with explicit columnGapPt configuration. Add three-line column and multiple-font-run reading-order regressions.
Red evidence: CI run 41219539796 at 2ea920c failed precisely the two new column regressions and restored auto-width table case. Green evidence: CI run https://github.com/easy-4-java/easypdf/actions/runs/41219759465 at db27b05 completed successfully: full clean verify, 174 tests (122 XHTML), zero failures/errors/skips. The original Chinese/Latin round-trip test and coverage configuration remain unchanged. Existing JaCoCo missing-exec/report warnings mean coverage is not certified. Local cloud environment has no Maven/compiler; validation uses the existing JDK 21 GitHub Actions full clean verify. Draft pending independent review.