Repository navigation
Conversation
The module-level duckdb.read_json() and duckdb.write_csv() accept a keyword-only `connection` argument at runtime (see their registrations in src/duckdb_python.cpp), but the stubs did not declare it, so type checkers rejected valid calls. Fixes duckdb#627 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Member
|
Thank you for the careful PR and the table of checker results, and sorry for the silence. Since you opened it, the 2.0 line moved the module level read_json and write_csv into Python, and those functions declare connection= themselves, so the stubs you edited no longer exist. I checked your repro against 2.0.0 and mypy reports no errors. I am closing this as superseded. Thanks again for tracking down the gap. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #627
The module-level
duckdb.read_json()andduckdb.write_csv()accept a keyword-onlyconnectionargument at runtime (both registrations insrc/duckdb_python.cppend withnb::arg("connection").none() = nb::none()), but_duckdb-stubs/__init__.pyidoesn't declare it. This PR adds it to both stubs in the same formread_parquetalready uses.I also compared every
m.def(...)insrc/duckdb_python.cppthat takesconnectionagainst the module-level stubs. These two are the only functions where it was missing.Testing
I type-checked the reproduction script from the issue against the duckdb 1.5.6 wheel, swapping in the stubs:
mainNo parameter named "connection")At runtime the script runs fine either way.