Skip to content

Slight improvements and corrections - #74

Merged
dtcooper merged 6 commits into
dtcooper:masterfrom
polyvertex:master
Oct 13, 2018
Merged

dtcooper merged 6 commits into
dtcooper:masterfrom
polyvertex:master

Conversation

@polyvertex

@polyvertex polyvertex commented Jul 18, 2018 •

Copy link
Copy Markdown
Contributor

Here are some slight improvements and corrections made while working on refactoring fitparse. Not sure they all fit your contribution policy but feel free to cherry-pick and thanks for having developed and maintained this lib!

@dtcooper

Copy link
Copy Markdown
Owner

I'm okay to merge this. Looks good to me! However, I'd like @pR0Ps or @xmedeko to have a look as well. :)

@xmedeko

xmedeko commented Jul 18, 2018

Copy link
Copy Markdown
Contributor

Looks good to me. Just have not reviewed the upgraded FIT profile from v20.33 to v20.66 commit.

@dtcooper

Copy link
Copy Markdown
Owner

These commits look good to me, so merging in.

@dtcooper
dtcooper merged commit 5c374ce into dtcooper:master Oct 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants