Skip to content

Add Makefile - #2529

Merged
sobolevn merged 3 commits into
dry-python:masterfrom
Khabib73:chore/makefile
Oct 8, 2026
Merged

sobolevn merged 3 commits into
dry-python:masterfrom
Khabib73:chore/makefile

Conversation

@Khabib73

@Khabib73 Khabib73 commented Oct 8, 2026

Copy link
Copy Markdown
Contributor
  • Documented ruff in CONTRIBUTING.md: ruff check and ruff format
    were running via pre-commit hooks but were missing from the docs.
  • Added a Makefile with all common commands (help, format, lint,
    type-check, unit, typesafety, slots, package, test) to make
    local development more user-friendly.

@codspeed

codspeed Bot commented Oct 8, 2026 •

Copy link
Copy Markdown
Contributor

Merging this PR will improve performance by 10.05%

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 1 improved benchmark
✅ 21 untouched benchmarks

Performance Changes

Mode Benchmark BASE HEAD Efficiency
⚡ Simulation test_safe_decorator 77.4 µs 70.3 µs +10.05%

Tip

Curious why performance improved? Comment @codspeedbot explain why performance improved on this PR, or directly use the CodSpeed MCP with your agent.


Comparing Khabib73:chore/makefile (e1fe25d) with master (1739834)

Open in CodSpeed

@codecov

codecov Bot commented Oct 8, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (82ef3ef) to head (e1fe25d).
⚠️ Report is 624 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##            master     #2529    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files           80        81     +1     
  Lines         2485      2564    +79     
  Branches       437        44   -393     
==========================================
+ Hits          2485      2564    +79     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sobolevn sobolevn left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, use makefile in CI, otherwise it won't be up-to-date

Comment thread .github/workflows/test.yml Outdated

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be changed as well

@sobolevn
sobolevn merged commit 791345f into dry-python:master Oct 8, 2026
26 checks passed
@Khabib73
Khabib73 deleted the chore/makefile branch October 8, 2026 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants