Skip to content

Policy about adding additional PHP extensions #28

Open

Description

@slashrsm

A lot of times one needs to add additional PHP extensions. While some of them are solving very custom requirements others can be more common. For example, I'd need redis support. What is the policy about that? Is it possible to add more extensions or should we create a fork and own build?

Activity

  1. zaporylie commented on May 18, 2016

    @zaporylie
    Member

    Hi @slashrsm

    Sorry for late response but I was away from my computer due to holiday season in Norway.
    I don't see any major issues to add Redis extension to generic PHP images.

    Minor issues:

    • overhead for people who doesn't use it
    • additional MB to image size
    • additional extension to maintain manually

    I think those minor issues are acceptable. I believe we could also create drupaldocker/redis which is 1-to-1 copy of official Redis (see drupaldocker/elasticsearch for reference).

    I hope we can meet and discuss topics related to drupal-docker initiative (i.e. php extensions policy) during DDD Milano.

  2. zaporylie commented on May 18, 2016

    @zaporylie
    Member

    I the mean time I've created https://github.com/drupal-docker/redis and gave you write permission. Feel free to fill it with Dockerimages.

  3. slashrsm commented on May 18, 2016

    @slashrsm
    ContributorAuthor

    Thank you for your feedback.

    I believe we could also create drupaldocker/redis which is 1-to-1 copy of official Redis (see drupaldocker/elasticsearch for reference).

    What is the benefit of maintaining an image that is exact copy of the default one?

    I hope we can meet and discuss topics related to drupal-docker initiative (i.e. php extensions policy) during DDD Milano.

    Sure, that would be great! There is also a session about Docker it seems: http://milan2016.drupaldays.org/node/137

  4. zaporylie commented on May 18, 2016

    @zaporylie
    Member

    What is the benefit of maintaining an image that is exact copy of the default one?

    We can instruct people (i.e. in docker-compose.yml) to use images from our namespace (vendor). Images which will be always compatible with Drupal. Right now there's probably nothing to be added to official Redis image but I expect one day we might want to ship it with additional .conffile.

    I believe this is small step for us right now. Almost nothing to maintain, since it will be automatically synced with base image, but adds much more flexibility for the future.

  5. iBobik commented on Jul 25, 2018

    @iBobik

    How about to reconsider extensions with the radmap (#83) in mind - moving to alpine-only?

    I think it is not justifiable to add extensions what will not be used on most of projects, e.g. Redis, Memcached. Also alternative DB drivers should be considered - pdo_pgsql and it's deps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions