You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Refactor: need clarification for TODO (shared base for Chat and Completion) #342
I just need a clarification as I am planning to open a PR for this. There’s a TODO in the codebase about unifying “Chats and Completions” (rigging/completion.py L34–35)
The TODO doesn’t say whether that means the Chat and Completion classes (what you get back from .run()) or the ChatPipeline and CompletionPipeline classes (what you call .run() on). Which pair should we unify under a shared base?
There’s duplication in both places: the Chat/Completion models share fields like uuid, timestamp, metadata, stop_reason, usage etc. The pipeline classes share generator, params, metadata, and methods like with_(), catch(), and clone().
changed the title [-]Refactor: need clarification for TODO (shared base for Chat and Completion pipelines)[/-][+]Refactor: need clarification for TODO (shared base for Chat and Completion)[/+]on Feb 17, 2026
Activity
[-]Refactor: need clarification for TODO (shared base for Chat and Completion pipelines)[/-][+]Refactor: need clarification for TODO (shared base for Chat and Completion)[/+]l50 commentedon Mar 13, 2026
@monoxgas you want to speak to this as the creator of the TODO?