Repository navigation
Add mountMockAreas and note native-link Enter handling - #1
Conversation
mountMockAreas re-parents the fictional mock areas under a caller-supplied university so consumers can drop the hand-written seed wiring. The README notes that gridAction is not on the activate path for native links once Enter is removed from the keymap. Co-authored-by: Oskar Freye <oskar@freye.tech>
|
No actionable comments were generated in the recent review.
 |
| Layer / File(s) | Summary |
|---|---|
Mount API and seed construction src/adapters/memory-knowledge/mount-mock-areas.ts, src/adapters/index.ts |
Adds and exports mountMockAreas. It rejects roots that are not universities, clones the supplied root, reparents mock areas, and includes cells and links based on the selected levels and cells. |
Mount behavior validation and documentation test/knowledge-adapters.test.ts, README.md, ARCHITECTURE.md |
Tests the mounted seed contents, navigation, root validation, and input immutability. Documents the function and its output. |
Native Link Keyboard Guidance
| Layer / File(s) | Summary |
|---|---|
Enter key guidance and keymap test test/grid-keyboard.test.ts, README.md |
Documents that removing Enter from the keymap allows native link activation without calling gridAction. Tests that Enter and Numpad Enter return no intent while Space remains bound. |
Estimated code review effort: 3 (Moderate) | ~20 minutes
Change: Feature
Merge Risk: 
1fe8e
-
No merge-blocking issue remains identified.
Security architecture risk: 1fe8e
-
The new API constructs an isolated copy of fictional sample data beneath a caller-supplied university. The reviewed changes introduce no external endpoint, privileged operation or persistent-state transition, and no material security risk was identified.
Retained concerns
No architecture-level concerns identified.Security review details
-
Security Blast Radius
- inferred — The added authority is limited to constructing an in-process seed for the caller. The helper does not access another tenant, external service, credential or durable store; any later application exposure depends on the consuming application.
Trust Boundaries and Controls
- observed — The university-kind check is structural validation, not authentication or authorization. Caller-controlled root data is copied into the returned seed. The existing repository already accepts arbitrary caller-supplied seeds and clones them, so this helper does not bypass a repository access-control gate.
-
Pre-merge checks: 
-
Check name Status Explanation Resolution Docstring Coverage Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat… Write docstrings for the functions missing them to satisfy the coverage threshold. -
Check name Status Explanation Description Check Check skipped - CodeRabbit’s high-level summary is enabled. Title check The title clearly identifies both main changes: adding mountMockAreasand documenting native-link Enter handling.Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage
-
Explanation
Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 1 functions across 4 files. (2 skipped: 2 unsupported.)
Resolution
Write docstrings for the functions missing them to satisfy the coverage threshold.
-
Finishing Touches
-
Generate docstrings
-
- Commit to this branch
- Create a new PR
Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Summary
mountMockAreasfrom@draht/hex/adapters. Pass a university level (for example{ ref: { kind: 'university', id: 'uni' }, title: 'Uni' }) and it returns aKnowledgeSeedwhose root is that level, with each fictional mock area'sparentset to it. Person levels under those areas, and the cells and links that belong to the areas and persons, are copied.MOCK_KNOWLEDGEand the level you pass in are not mutated. The mock university and the cells on its grid stay out, so the root grid is empty for the app's own cells; the areas are children of the root (listChildren, breadcrumbs).gridActionis not needed foractivateon native links whenEnteris removed from the keymap. This matches the code.lookupBindingtriescodefirst, thenkey, and the default entry is namedEnter, so dropping that entry makeskeyIntentreturn null for the Enter key and for Numpad Enter (code: 'NumpadEnter',key: 'Enter'). A listener that callspreventDefaultandgridActiononly whenkeyIntentis non-null leaves the key to the browser, which follows the link. Space stays anactivatebinding, and a native link does not follow on Space, so Space still goes throughgridAction. The note sits with the keymap rules and next to thegridActionactivate description.Test plan
bun run check: TypeScript 6.x typecheck, TypeScript 5.9 typecheck, andbun test(110 pass, 0 fail), including the newmountMockAreastests and a keymap test that Enter and Numpad Enter are unbound once theEnterentry is removedNo version bump and no publish.
Open in [code]smith · Need help on this PR? Tag
@codesmith-botwith what you need.Summary by CodeRabbit
New Features
Documentation
Enterfrom a custom keymap affects native link activation.Spaceremains an activation key unless removed separately.