how to append the command after arugment? #97

Activity

1. PFtyrant

   changed the title [-]how to append the command after arugments?[/-] [+]how to append the command after arugment?[/+] on Jun 30, 2024
2. filka55533 commented on Jun 30, 2024

   

   filka55533

   on Jun 30, 2024

   Last edited by filka55533

   More actions

   Hello! You can dispatch it only with very hard validation callback on snooping command. I think, you have very hard command hierarchy. You can define vlan config mode, where you can store context within all required data about vlan, and declare commands, that would be enable on vlan config mode.

   #define MODE_CONFIG_VLAN 0x02
   struct vlan_context {
     // Add all fields that you need for vlan
   };
   
   int config_vlan(struct cli_def *cli, const char *command, char *argv[], int argc);
   
   void initialize_commands(struct cli_def *cli) {
     struct cli_def *c;
     c = cli_register_command(cli, NULL, "vlan", config_vlan, PRIVILEGE_PRIVILEGED, MODE_CONFIG,
                              "Configure VLAN");
   
     c = cli_register_command(cli, c, "ip", NULL, PRIVILEGE_PRIVILEGED, MODE_CONFIG, "ip help");
     c = cli_register_command(cli, c, "igmp", NULL, PRIVILEGE_PRIVILEGED, MODE_CONFIG,
                              "igmp help");
     c = cli_register_command(cli, c, "snooping", NULL, PRIVILEGE_PRIVILEGED, MODE_CONFIG,
                              "snooping help");
     c = cli_register_command(cli, c, "mrouter", NULL, PRIVILEGE_PRIVILEGED, MODE_CONFIG_VLAN,
                              "mrouter help");
     c = cli_register_command(cli, c, "interfaces", NULL, PRIVILEGE_PRIVILEGED, MODE_CONFIG_VLAN,
                              "interfaces help");
   }
   
   int config_vlan(struct cli_def *cli, const char *command, char *argv[], int argc) {
     static struct vlan_context ctx;
     // Your validation routine, if no argument should be use -- set default vlan id
     ...
     // If all is ok
     cli_set_context(cli, (void *)&ctx);
     cli_set_configmode(cli, MODE_CONFIG_VLAN, "vlan");
   }

   And than you can config it as

   your_proj> enable 
   your_proj# configure terminal
   your_proj(config)# vlan 12
   your_proj(config-vlan)# ip igmp snooping mrouter interfaces <INTERFACE-LIST>

   For my opinion this would be much easier, than when you would write snooping command callback.

   👍React with 👍1Reacted by kris_teng
3. PFtyrant commented on Jul 1, 2024

   

   PFtyrant

   on Jul 1, 2024

   Author

   More actions

   Thanks for your reply, @filka55533. it is a good opinion. Unfortunately, we don't want to modify the CLI command hierarchy. So, regarding question 2, is there any way to solve it?
4. filka55533 commented on Jul 1, 2024

   

   filka55533

   on Jul 1, 2024

   More actions

   Just look on example with perimeter command on clitest.c . On optarg shape you can see function shape_transient_eval, where according to the shape (rectangle or triangle) should be setting new MODE_CONFIG_* mode. You can use same technique, where you should be enable your new mode (f.e. MODE_CONFIG_VLAN) and register other commands (mrouter and interfaces) only for this new mode like on the clitest.c file with side_1-4 arguments. But this solution would be harder to scale for new command if compare it with my previous solution, keep in mind it.