Visual Studio support #61

Activity

1. RobSanders commented on Nov 18, 2020

   

   RobSanders

   on Nov 18, 2020

   Collaborator

   More actions

   I personally do not use Visual Studio, and also have not tried to build on Windows as my target platform is Linux. David may be able to offer more insight as the original developer. On my current Linux box (CentOS 7) /usr/include/unistd.h has an internal include guard already in it.
2. BenjiHansell commented on Nov 18, 2020

   

   BenjiHansell

   on Nov 18, 2020

   Author

   More actions

   Thanks @RobSanders

   To clarify, in my original post where I referred to "the unguarded #include <unistd.h>", I just meant that I would expect to see that include excluded from MSVC builds, e.g.:

   #ifndef WIN32
   #include <unistd.h>
   #endif
   
3. RobSanders commented on Nov 18, 2020

   

   RobSanders

   on Nov 18, 2020

   Collaborator

   More actions

   Ah, understand now. I did a quick check in some older versions (1.9.5, 1.9.6, 1.9.7)and it looks like the include for unistd.h has not been inside a WIN32 guard check for several years. Not saying it shouldn't be, but as mentioned, I've never built this for Windows.
4. dparrish commented on Nov 19, 2020

   

   dparrish

   on Nov 19, 2020 via email

   Owner

   More actions

   I am also a Linux-only builder, so I can't be of much help to you there. There were previously users on the win32 platform that added the guards. They said it worked on win32, and it still worked on Linux so I merged the patches. I'd still be happy to merge further patches for it to compile on modern Windows if you want to fix it?

   …

   On Thu, Nov 19, 2020 at 3:02 AM Rob Sanders ***@***.***> wrote: Ah, understand now. I did a quick check in some older versions (1.9.5, 1.9.6, 1.9.7)and it looks like the include for unistd.h has not been inside a WIN32 guard check for several years. Not saying it shouldn't be, but as mentioned, I've never built this for Windows. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#61 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AABPIQZMOYNR2MAMAGBBN5TSQPVY7ANCNFSM4T2CDO3A> .
5. BenjiHansell commented on Nov 19, 2020

   

   BenjiHansell

   on Nov 19, 2020

   Author

   More actions

   @dparrish thanks for your explanation. So far, my attempts to patch the latest release for Windows haven't got me far. If I do succeed, I'll be sure to contribute it back. Thank you for your time.