Repository navigation
Document ZIP checksum parameter values - #581
Merged
jonathanpeppers merged 2 commits intoAug 16, 2026
Merged
Conversation
Refs #256 Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
This PR improves the generated XML documentation for Java.Util.Zip checksum APIs by replacing placeholder text with concrete parameter/value descriptions, aligning the docs more closely with the underlying Java/Android reference semantics.
Changes:
- Documented
off/lenparameter meanings forUpdate(byte[] b, int off, int len)inCRC32andAdler32. - Documented the
Valueproperty description forAdler32.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| docs/xml/Java.Util.Zip/CRC32.xml | Replaces placeholder parameter docs for Update(byte[], int, int). |
| docs/xml/Java.Util.Zip/Adler32.xml | Replaces placeholder parameter docs for Update(byte[], int, int) and fills in the Value property <value> description. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Refs #256 Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Member
Author
|
@dalexsoto review |
dalexsoto
approved these changes
Aug 16, 2026
dalexsoto
left a comment
dalexsoto
left a comment
Member
There was a problem hiding this comment.
The Adler32 and CRC32 update parameter/value contracts now match Android and the managed signatures.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #256
Sources
Validation
git diff --check.