Repository navigation
Complete PDF selection runtime documentation - #1146
Conversation
Document the explicit IJavaPeerable.UnregisterFromRuntime members using the canonical .NET interface contract. Refs #112. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
🟢 Approval recommended
The four documentation replacements match the canonical interface contract and explicit implementation metadata, with no unresolved issues.
No open issues 🎉
What changed in this PR
Completes the four remaining documentation placeholders in Android.Graphics.Pdf.Models.Selection by documenting the .NET-only UnregisterFromRuntime implementations.
Changes:
- Adds summaries describing the canonical runtime-unregistration contract.
- Adds remarks explaining explicit interface implementation and how to call the members.
- Leaves API metadata and existing documentation unchanged.
| File | Description |
|---|---|
docs/xml/Android.Graphics.Pdf.Models.Selection/SelectionBoundary.xml |
Replaces the unregistration summary and remarks placeholders. |
docs/xml/Android.Graphics.Pdf.Models.Selection/PageSelection.xml |
Replaces the unregistration summary and remarks placeholders. |
Review effort: Balanced
Use the complete nested-type DocId and parameter signature for the two new links. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
|
@dalexsoto review |
dalexsoto
left a comment
There was a problem hiding this comment.
The four explicit runtime-unregistration placeholders match the canonical IJavaPeerable contract and exact DocIds, while the complete namespace scope and surrounding API metadata are preserved.
Source-only documentation and static integration review; no converter or installed-runtime execution is claimed.
Summary
Replace the last four exact XML placeholders in
Android.Graphics.Pdf.Models.Selection: the summary and remarks of the explicitJava.Interop.IJavaPeerable.UnregisterFromRuntimeimplementation inPageSelection.xmlandSelectionBoundary.xml.Both members declare
M:Java.Interop.IJavaPeerable.UnregisterFromRuntimein theirImplementsmetadata. The summaries use the canonical contract: unregistering prevents futureJniValueManager.PeekValuecalls from returning the instance. The remarks identify the explicit interface implementation and how to call it.Sources:
docs\xml\Java.Interop\IJavaPeerable.xml, memberUnregisterFromRuntime.These are .NET-only interface implementations, so no Android/Java importer or Java mapping is used. Existing documentation, API metadata, attribution, and file formatting are unchanged.
Verification
Full scan of
docs\xml\Android.Graphics.Pdf.Models.Selectionplusdocs\xml\ns-Android.Graphics.Pdf.Models.Selection.xml, excluding generated index/filter/framework files:PageSelection.xmlSelectionBoundary.xmlPageSelection+InterfaceConsts.xmlSelectionBoundary+InterfaceConsts.xmlns-Android.Graphics.Pdf.Models.Selection.xmlExact placeholder counts use XML elements whose entire text is
To be added.rather than substring matches. Phrase matches also decreased from 4 to 0. Legitimate non-placeholder phrase matches: 0 before and 0 after.All five XML files parse. A comparison against the base confirms that only the four placeholder elements changed.
git diff --checkand the committed diff check pass.Fixes: #112
The full issue scope has zero actual placeholders in this change. The closing reference takes effect when the PR is merged; the local count alone is not a completed merge.