Skip to content

Complete PDF selection runtime documentation - #1146

Merged
jonathanpeppers merged 2 commits into
mainfrom
jonathanpeppers-complete-pdf-selection-docs
Oct 23, 2026
Merged

jonathanpeppers merged 2 commits into
mainfrom
jonathanpeppers-complete-pdf-selection-docs

Conversation

@jonathanpeppers

@jonathanpeppers jonathanpeppers commented Oct 23, 2026 •

Copy link
Copy Markdown
Member

Summary

Replace the last four exact XML placeholders in Android.Graphics.Pdf.Models.Selection: the summary and remarks of the explicit Java.Interop.IJavaPeerable.UnregisterFromRuntime implementation in PageSelection.xml and SelectionBoundary.xml.

Both members declare M:Java.Interop.IJavaPeerable.UnregisterFromRuntime in their Implements metadata. The summaries use the canonical contract: unregistering prevents future JniValueManager.PeekValue calls from returning the instance. The remarks identify the explicit interface implementation and how to call it.

Sources:

These are .NET-only interface implementations, so no Android/Java importer or Java mapping is used. Existing documentation, API metadata, attribution, and file formatting are unchanged.

Verification

Full scan of docs\xml\Android.Graphics.Pdf.Models.Selection plus docs\xml\ns-Android.Graphics.Pdf.Models.Selection.xml, excluding generated index/filter/framework files:

File Before After
PageSelection.xml 2 0
SelectionBoundary.xml 2 0
PageSelection+InterfaceConsts.xml 0 0
SelectionBoundary+InterfaceConsts.xml 0 0
ns-Android.Graphics.Pdf.Models.Selection.xml 0 0
Exact XML placeholders 4 0

Exact placeholder counts use XML elements whose entire text is To be added. rather than substring matches. Phrase matches also decreased from 4 to 0. Legitimate non-placeholder phrase matches: 0 before and 0 after.

All five XML files parse. A comparison against the base confirms that only the four placeholder elements changed. git diff --check and the committed diff check pass.

Fixes: #112

The full issue scope has zero actual placeholders in this change. The closing reference takes effect when the PR is merged; the local count alone is not a completed merge.

Document the explicit IJavaPeerable.UnregisterFromRuntime members using the canonical .NET interface contract. Refs #112.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot AI balanced review requested due to automatic review settings October 23, 2026 15:33

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The four documentation replacements match the canonical interface contract and explicit implementation metadata, with no unresolved issues.

No open issues 🎉

What changed in this PR

Completes the four remaining documentation placeholders in Android.Graphics.Pdf.Models.Selection by documenting the .NET-only UnregisterFromRuntime implementations.

Changes:

  • Adds summaries describing the canonical runtime-unregistration contract.
  • Adds remarks explaining explicit interface implementation and how to call the members.
  • Leaves API metadata and existing documentation unchanged.
File Description
docs/​xml/​Android.Graphics.Pdf.Models.Selection/​SelectionBoundary.xml Replaces the unregistration summary and remarks placeholders.
docs/​xml/​Android.Graphics.Pdf.Models.Selection/​PageSelection.xml Replaces the unregistration summary and remarks placeholders.

Review effort: Balanced

Use the complete nested-type DocId and parameter signature for the two new links.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@jonathanpeppers

Copy link
Copy Markdown
Member Author

@dalexsoto review

@dalexsoto dalexsoto left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The four explicit runtime-unregistration placeholders match the canonical IJavaPeerable contract and exact DocIds, while the complete namespace scope and surrounding API metadata are preserved.

Source-only documentation and static integration review; no converter or installed-runtime execution is claimed.

@jonathanpeppers
jonathanpeppers merged commit ae74444 into main Oct 23, 2026
3 checks passed
@jonathanpeppers
jonathanpeppers deleted the jonathanpeppers-complete-pdf-selection-docs branch October 23, 2026 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add XML documentation for Android.Graphics.Pdf.Models.Selection

3 participants