Skip to content

Factory vs inject - #259

Open
bidi47 wants to merge 3 commits into
developfrom
factory-vs-inject
Open

bidi47 wants to merge 3 commits into
developfrom
factory-vs-inject

Conversation

@bidi47

@bidi47 bidi47 commented Oct 1, 2026

Copy link
Copy Markdown
Member

No description provided.

@bidi47
bidi47 requested a review from arhimede October 1, 2026 20:31
@bidi47 bidi47 linked an issue Oct 1, 2026 that may be closed by this pull request
@arhimede

arhimede commented Oct 2, 2026

Copy link
Copy Markdown
Member

@alexmerlin can you check this one ?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comparing attributes with factories is like saying "car engines vs bikes", because just like car engines are a key part of cars, attributes are a key part of dependency injection.
What we want to compare is probably "dependency injection vs factories".

By changing this, probably the whole article will change fundamentally.
So, I will continue my review when the updated version has landed.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but aren't attributes and factories implementation styles for dependency injection? so the comparison becomes #[Inject] vs. hand-written factories. i'll add this to the next update, along with some fixes for inconsistencies, and then request another review

Signed-off-by: bidi47 <bidi@apidemia.com>
@codecov

codecov Bot commented Oct 5, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 68.17%. Comparing base (d7a9cf1) to head (be4572c).
⚠️ Report is 8 commits behind head on develop.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop     #259   +/-   ##
==========================================
  Coverage      68.17%   68.17%           
  Complexity       597      597           
==========================================
  Files             95       95           
  Lines           2300     2300           
==========================================
  Hits            1568     1568           
  Misses           732      732           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@bidi47
bidi47 requested a review from alexmerlin October 5, 2026 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

factory versus inject

3 participants