Skip to content

Lock() of Locker interface should probably take a receive-only channel #175

Open

Description

@debedb

Lock() of Locker interface should probably take a receive-only channel for stopChan, that is, instead of

Lock(stopChan chan struct{}) (<-chan struct{}, error)

have

Lock(<-stopChan chan struct{}) (<-chan struct{}, error)

Lock would not be writing to stopChan, the user of the Lock will - and this signature will allow using things like Context's Done channel directly (without mediating it with another select).

Activity

  1. added a commit that references this issue on Aug 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions