service --log-opt only works if you also specify --log-driver #8745

Activity

1. paigehargrave commented on Jun 1, 2019

   

   paigehargrave

   on Jun 1, 2019

   Contributor

   More actions

   @thaJeztah Not sure if there's still an issue here (per moby/moby#31515 (comment)) - can you PTAL when you have a free moment (har har). Thanks!
2. thaJeztah commented on Jun 12, 2019

   

   thaJeztah

   on Jun 12, 2019

   Member

   More actions

   Thanks @Tomcat-Engineering (and thanks for the ping @paigehargrave)

   Hm.. alright; so this looks to be a combination of something that's by design, and (what I think is) a bug in the docker service update logic; docker service create and update should follow slightly different logic (and I think they currently use the same).

   • expected: setting log-opt for a service that does not have a logging-driver configured isn't supported
     • reason for this is Docker ignores --log-opt (1.12.6) moby/moby#31515 (comment) that in a swarm setup, all instances of a service should use the same configuration (including logging-driver), so when specifying options, they must be accompanied with the driver
   • t.b.d.: creating a service with a log-opt set, but no logging driver silently ignores the option
     • should it produce an error? a warning?
   • bug: setting log-opt for a service that has a logging driver configured (when created), but without specifying that driver during update is silently ignored.
     • when updating a service, the CLI should take the existing logging-driver, and update the options

   Taking a full example;

   docker service create --log-driver=json-file --log-opt max-file=5 --name loggie nginx:alpine
   docker service inspect --format='{{json .Spec.TaskTemplate.LogDriver}}' loggie
   {"Name":"json-file","Options":{"max-file":"5"}}

   Updating without logging-driver set doesn't take effect. IMO this should work, given that the service already had a logging-driver configured. It should still fail (or warn) if no logging-driver was configured yet on the service.

   docker service update --log-opt max-file=15 loggie
   docker service inspect --format='{{json .Spec.TaskTemplate.LogDriver}}' loggie
   {"Name":"json-file","Options":{"max-file":"5"}}

   Updating with a logging driver specified does;

   docker service update --log-driver=json-file --log-opt max-file=15 loggie
   docker service inspect --format='{{json .Spec.TaskTemplate.LogDriver}}' loggie
   {"Name":"json-file","Options":{"max-file":"15"}}

   So, I agree that we should document this (or at least make sure that any example we have does use the right combination). This bug doesn't look critical (and there's a workaround), so likely won't find its way back in all older releases (e.g. likely won't be fixed in Docker Enterprise 17.06), so having this documented would be useful even if it might be fixed in a future update.

   I'll copy the information here to the docker/cli issue tracker (where I think the bug is), and will post a link to that issue here.
3. thaJeztah commented on Jun 12, 2019

   

   thaJeztah

   on Jun 12, 2019

   Member

   More actions

   opened docker/cli#1942
4. traci-morrison

   added

   area/engineIssue affects Docker engine/daemonIssue affects Docker engine/daemon

   on Dec 10, 2019
5. docker-robott commented on Nov 30, 2022

   

   docker-robott

   on Nov 30, 2022

   Collaborator

   More actions

   There hasn't been any activity on this issue for a long time.
   If the problem is still relevant, mark the issue as fresh with a /remove-lifecycle stale comment.
   If not, this issue will be closed in 14 days. This helps our maintainers focus on the active issues.

   Prevent issues from auto-closing with a /lifecycle frozen comment.

   /lifecycle stale
6. docker-robott

   added

   lifecycle/stale

   on Nov 30, 2022
7. docker-robott

   closed this as completedon Dec 14, 2022
8. docker-robott commented on Jan 13, 2023

   

   docker-robott

   on Jan 13, 2023

   Collaborator

   More actions

   Closed issues are locked after 30 days of inactivity.
   This helps our team focus on active issues.

   If you have found a problem that seems similar to this, please open a new issue.

   /lifecycle locked
9. docker

   locked and limited conversation to collaborators on Jan 13, 2023
10. docker-robott

    added

    lifecycle/locked

    on Jan 13, 2023