Skip to content

[WiP] Enable docker-compose for the latest compose-spec - #7459

Closed
EricHripko wants to merge 4 commits into
docker:masterfrom
EricHripko:compose-spec
Closed

EricHripko wants to merge 4 commits into
docker:masterfrom
EricHripko:compose-spec

Conversation

@EricHripko

Copy link
Copy Markdown

Overview

This PR updates docker-compose with the latest version of the schema as specified by compose-spec. This (among other things) enables condition: service_healthy to be used in v3 format. I've copied the minimum API/Docker versions from the current latest, as I don't think any new features rely on the newer API/daemon. Please feel free to correct me if not 🙈

Testing

  • Manually verified that I am able to load a docker-compose.yaml with version: '3.9'

@EricHripko

Copy link
Copy Markdown
Author

❌ Pre-commit hooks fail for the following reason:

@ndeloof

ndeloof commented May 19, 2020

Copy link
Copy Markdown
Contributor

@EricHripko schema on compose-spec is not version 3.9, this is a WiP.
We still have to define how we plan to release schema versions, and get them used by tools like docker CLI and docker-compose. Or maybe consider compose-spec/compose-spec#13

@ulyssessouza

Copy link
Copy Markdown
Contributor

Hello @EricHripko, about the CI, #7473 will fix this, then you just need to rebase it after it's merged.
Considering @ndeloof's comment I will convert this PR to a draft PR just to mark it.

@ulyssessouza
ulyssessouza marked this pull request as draft May 20, 2020 08:57
@EricHripko

Copy link
Copy Markdown
Author

Makes sense - thank you 👍 I'll rebase my PRs once your fix lands

Signed-off-by: Eric Hripko <ehripko@bloomberg.net>
Addresses the trailing whitespace issue
Signed-off-by: Eric Hripko <ehripko@bloomberg.net>
Signed-off-by: Eric Hripko <ehripko@bloomberg.net>
@EricHripko

Copy link
Copy Markdown
Author

Based on the issue mentioned by @ndeloof above, pivoting to require no version.

Signed-off-by: Eric Hripko <ehripko@bloomberg.net>
@EricHripko

Copy link
Copy Markdown
Author

The associated compose-spec change was landed, so gonna mark this PR as ready 🙂

@EricHripko
EricHripko marked this pull request as ready for review June 8, 2020 10:16
@ndeloof ndeloof changed the title Enable docker-compose for the latest compose-spec [WiP] Enable docker-compose for the latest compose-spec Jun 8, 2020
@ndeloof

ndeloof commented Jun 8, 2020

Copy link
Copy Markdown
Contributor

compose-spec json schema should not be set a 3.9, especially now that we adopted compose-spec/compose-spec#13

Please also not spec is not yet ready for this, as it does not (yet) include all v2 attributes. For this reason I marked this PR as "Work in Progress"

@EricHripko
EricHripko marked this pull request as draft June 8, 2020 14:36
@EricHripko

Copy link
Copy Markdown
Author

@ndeloof - thanks for pointing that out, I'll update the schema to name no version.

I've checked the PRs on the spec and can't see anything v2-related pending. What attributes are remaining? How I can I help?

@ndeloof

ndeloof commented Jun 12, 2020

Copy link
Copy Markdown
Contributor

I need to double check the possibly missing v2 attributes, at least we need to clarify expectation about extend in compose-spec

@EricHripko

Copy link
Copy Markdown
Author

This is addressed by @aiordache in this PR: #7588. Since linked PR seems to have gotten more traction I'll close this one.

@EricHripko EricHripko closed this Jul 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants