Repository navigation
[WiP] Enable docker-compose for the latest compose-spec - #7459
EricHripko wants to merge 4 commits into
Conversation
|
❌ Pre-commit hooks fail for the following reason:
|
|
@EricHripko schema on compose-spec is not version 3.9, this is a WiP. |
|
Hello @EricHripko, about the CI, #7473 will fix this, then you just need to rebase it after it's merged. |
|
Makes sense - thank you 👍 I'll rebase my PRs once your fix lands |
Signed-off-by: Eric Hripko <ehripko@bloomberg.net>
Addresses the trailing whitespace issue Signed-off-by: Eric Hripko <ehripko@bloomberg.net>
Signed-off-by: Eric Hripko <ehripko@bloomberg.net>
|
Based on the issue mentioned by @ndeloof above, pivoting to require no version. |
Signed-off-by: Eric Hripko <ehripko@bloomberg.net>
|
The associated compose-spec change was landed, so gonna mark this PR as ready 🙂 |
|
compose-spec json schema should not be set a Please also not spec is not yet ready for this, as it does not (yet) include all v2 attributes. For this reason I marked this PR as "Work in Progress" |
|
@ndeloof - thanks for pointing that out, I'll update the schema to name no version. I've checked the PRs on the spec and can't see anything v2-related pending. What attributes are remaining? How I can I help? |
|
I need to double check the possibly missing v2 attributes, at least we need to clarify expectation about |
|
This is addressed by @aiordache in this PR: #7588. Since linked PR seems to have gotten more traction I'll close this one. |
Overview
This PR updates
docker-composewith the latest version of the schema as specified by compose-spec. This (among other things) enablescondition: service_healthyto be used in v3 format. I've copied the minimum API/Docker versions from the current latest, as I don't think any new features rely on the newer API/daemon. Please feel free to correct me if not 🙈Testing
docker-compose.yamlwithversion: '3.9'