Repository navigation
Conversation
aiordache
requested review from
ndeloof,
rumpl and
ulyssessouza
as code owners
February 11, 2020 10:44
ndeloof
approved these changes
Feb 11, 2020
Signed-off-by: Anca Iordache <anca.iordache@docker.com>
aiordache
force-pushed
the
compose_compatibility_flag
branch
from
February 12, 2020 19:17
8268387 to
b6b85e4
Compare
Signed-off-by: Anca Iordache <anca.iordache@docker.com>
Contributor
|
@aiordache can you rebase your PR? 🙏 |
Contributor
|
@ulyssessouza PTAL 🦁 |
Contributor
|
@aiordache it looks like there are some test failures? |
Contributor
Author
|
Closing PR as #7588 covered this. |
2 of 14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We don't need to pass the compatibility argument anymore to parse the 'deploy' section of the config.
Using the --compatibility flag will not raise an exception but it will be ignored.
BEFORE
Only one container per service is created.
--compatibilityarg should be passed to get the deploy field parsedNOW
The number of containers to be created is set by the replicas field in the deploy section
Signed-off-by: Anca Iordache anca.iordache@docker.com
Resolves https://github.com/docker/dev-tooling-team/issues/121