Repository navigation
Conversation
docker logout left the config.json auth entry in place when a credHelper was set and the helper program failed. Other server address spellings still erased cleanly, so the command reported success. Fixes docker#2605 Signed-off-by: Dean Chen <862469039@qq.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
docker logoutprints that it removed the credentials, then asks the cred helper to erase. If that helper fails, the auth entry in config.json was left as-is. Logout also tries thehttp://andhttps://spellings, and those no-op erases counted as success, so there was no warning either.The plaintext copy is removed even when the helper returns an error. The helper error is still returned.
Fixes #2605