Repository navigation
Conversation
run and create register a local --help so -h can stay --hostname. That flag shadows the persistent one, and `docker --help run <image>` went ahead and started the container. Fixes docker#7473 Signed-off-by: Dean Chen <862469039@qq.com>
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
docker --help run hello-worldpulls and starts the container.runandcreatekeep a local--helpso-hcan stay--hostname, and that one shadows the persistent flag once it's already been parsed off.This prints that command's help instead.
docker run --helpstill works the same way, and--helpafter the image name is still just an argument.Fixes #7473