Repository navigation
vendor: golang.org/x/net v0.62.0 #7465
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[high] Vendored source files for golang.org/x/net not updated — binary will use v0.60.0 sources despite metadata claiming v0.62.0
The PR updates three metadata files (
vendor.mod,vendor.sum,vendor/modules.txt) to declaregolang.org/x/net v0.62.0, but the actual Go source files undervendor/golang.org/x/net/were not updated.git logconfirms the vendored sources were last updated in the commit for v0.60.0, not v0.61.0 or v0.62.0:The PR commit stat confirms only 3 metadata files changed — no source files under
vendor/golang.org/x/net/were touched.Impact: When building with
-mod=vendor(the default in Go when avendor/directory is present), the Go toolchain compiles directly from the vendored source files and ignores the module cache. Any changes made tohttp2,httpguts,idna, or other vendored packages between v0.60.0 and v0.62.0 will be absent from the compiled binary. The CVEs mentioned (CVE-2026-78661, CVE-2026-97045) are in thehtmlpackage which is not vendored, so those specific fixes are irrelevant here — but other bug fixes and changes in the vendored packages between v0.60.0 and v0.62.0 will be silently missing.Fix: Run
go mod vendor(or equivalent) to regenerate thevendor/directory with the v0.62.0 sources. The resulting diff should include changes to source files undervendor/golang.org/x/net/.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
None of the changes in this version are used in this repository, so it's expected that they don't show up in vendor.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're absolutely right, thank you for the clarification! I can see that v0.61.0 also only updated the metadata files (3 files changed), while v0.60.0 was the last version that actually changed vendored source files. This means the changes between v0.60.0 and v0.62.0 genuinely didn't affect any of the packages docker/cli vendors from
golang.org/x/net(http2, httpguts, idna, trace, etc.).I incorrectly assumed that every version bump must include source changes. In reality, when a module releases a new version but only modifies packages that aren't used by this project, vendoring only the metadata is correct behavior. My apologies for the noise!