Repository navigation
Remove gox, add support for s390x - #129
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #129 +/- ##
==========================================
+ Coverage 44.85% 46.12% +1.27%
==========================================
Files 169 161 -8
Lines 11376 11006 -370
==========================================
- Hits 5103 5077 -26
+ Misses 5981 5639 -342
+ Partials 292 290 -2 |
Contributor
Author
|
ping, this should be an easy review |
cpuguy83
reviewed
May 30, 2017
| "$BUILDDIR/linux-cross" \ | ||
| "$BUILDDIR/windows" \ | ||
| "$BUILDDIR/osx" \ | ||
| "GOARCH=amd64 $BUILDDIR/binary" \ |
Contributor
Author
There was a problem hiding this comment.
I guess right now it assumes that it's always run in a linux container, but that's not necessarily the case.
I've added GOOS=linux
Signed-off-by: Daniel Nephin <dnephin@docker.com>
Member
|
This didn't make it into 17.06.0 https://github.com/docker/docker-ce/blob/17.06/components/cli/scripts/build/cross#L7-L12 |
trapier
pushed a commit
to trapier/cli
that referenced
this pull request
Sep 30, 2019
…-19.03-c500b534e741395dd4f728f458dd0a95479de3a7 [19.03] sync to upstream 19.03 c500b53
nobiit
pushed a commit
to nobidev/docker-cli
that referenced
this pull request
Nov 19, 2025
[17.06] Changelog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #31
Removes
goxandscripts/build/linux-crossAdds support for linux/s390x
cc @andrewhsu @cpuguy83