Repository navigation
Make fails with make: *** [binary] Error 1 #94
Description
Make fails with the helpful error message of make: *** [binary] Error 1
A little debugging shows that https://github.com/docker/cli/blob/master/scripts/build/.variables#L7 is the issue.
On OSX:
$ date --utc --rfc-3339 ns
date: illegal option -- -
usage: date [-jnRu] [-d dst] [-r seconds] [-t west] [-v[+|-]val[ymwdHMS]] ...
[-f fmt date | [[[mm]dd]HH]MM[[cc]yy][.ss]] [+format]
I know that the README now shows the Dockerized make targets so this will only be an issue for people like me on OSX who didnt RTFM 😁
I guess it would be nice to be fixed or for the dockerized makefile to be the default one.
Activity
thaJeztah commentedon May 16, 2017
What exact command did you run?
make binaryor justmake?dave-tucker commentedon May 16, 2017
just
makednephin commentedon May 16, 2017
I believe I fixed this in #78 , are you on latest master?
Edit: actually I fixed it for alpine, but not for "host" development. I dont' think we can support developing on the host.
This is unfortunate, but that's how bash decides to error out on undefined variables with
set -u.dnephin commentedon May 16, 2017
This was discussed in #78 as well: #78 (comment)
I think we'll look at replacing
docker.Makefilewith a./build.shfor nowdave-tucker commentedon May 16, 2017
Yes I'm on latest master. Both
makeandmake binaryinsta-fail on OSX.thaJeztah commentedon May 16, 2017
Oh, 🤦 this is the docker/cli repo, ignore me
dnephin commentedon May 16, 2017
We could also add a check to the
Makefilethat warns if it's not being run from an expected environment. Maybedocker.Makefile(and the future./build.sh) could setDOCKER_CLI_THIS_IS_FINE=1. Anyone who has setup their host can export that as well to remove the warning.Then in
Makefileif the environment variable isn't set we can warn "you probably want./build.sh"dnephin commentedon Jun 1, 2017
This has been partially fixed by removing the "develop on the host" instructions from the README. We also have #99 to track other related improvements. #107 introduces the script I suggested here.
Going to close this issue since we have another tracking issue.
Merge pull request docker#94 from andrewhsu/fix-grpc