Skip to content

Add Alpine 3.18 #417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yosifkit merged 2 commits into from
May 10, 2023
Merged

Add Alpine 3.18 #417

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3ac53a7
Add Alpine 3.18
wheatevo May 10, 2023
10e743e
Remove Alpine 3.16 from most versions (max 2 supported Alpine version…
tianon May 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion 3.1/alpine3.16/Dockerfile → 3.1/alpine3.18/Dockerfile
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion 3.2/alpine3.16/Dockerfile → 3.2/alpine3.18/Dockerfile
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 4 additions & 4 deletions versions.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,8 @@
"slim-bullseye",
"buster",
"slim-buster",
"alpine3.17",
"alpine3.16"
"alpine3.18",
"alpine3.17"
],
"version": "3.1.4"
},
Expand Down Expand Up @@ -72,8 +72,8 @@
"slim-bullseye",
"buster",
"slim-buster",
"alpine3.17",
"alpine3.16"
"alpine3.18",
"alpine3.17"
],
"version": "3.2.2"
}
Expand Down
9 changes: 4 additions & 5 deletions versions.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,15 +75,14 @@ for version in "${versions[@]}"; do
empty # trailing comma hack
| ., "slim-" + .), # https://github.com/docker-library/ruby/pull/142#issuecomment-320012893
(
# Alpine 3.17 defaults to OpenSSL 3 which is not supported (yet?) by Ruby 2.7 or 3.0
# Alpine 3.17+ defaults to OpenSSL 3 which is not supported (yet?) by Ruby 2.7 or 3.0

@yosifkit yosifkit May 10, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The optimistic yet? has now resolved and OpenSSL 3 will not be supported in Ruby 2.7 or 3.0 (which also means that they will not work in debian:bookworm images):

We decided to not backport openssl-3.x gem into ruby_2_7 and ruby_3_0 branches. Because it affects with OpenSSL 1.0.x.

Unfortunately, the users should upgrade their ruby version to 3.1+ before upgrading their OS version.

- https://bugs.ruby-lang.org/issues/18658#note-18

Side note: 2.7 is already EOL (PR incoming) and 3.0 will be EOL in ~10 months (https://www.ruby-lang.org/en/downloads/branches/, https://endoflife.date/ruby)

# https://bugs.ruby-lang.org/issues/18658
# https://github.com/docker-library/ruby/pull/392#issuecomment-1329896174
if [ "2.7", "3.0" ] | index(env.version) then empty else
if [ "2.7", "3.0" ] | index(env.version) then "3.16" else
"3.18",
"3.17",
empty # trailing comma hack
end,
"3.16",
empty # trailing comma hack
end
| "alpine" + .)
],
}
Expand Down